Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

fix(web3-errors): the undefined data in Eip838ExecutionError #6905

Merged
merged 7 commits into from
Jul 11, 2024
Merged

fix(web3-errors): the undefined data in Eip838ExecutionError #6905

merged 7 commits into from
Jul 11, 2024

Conversation

Alfxjx
Copy link
Contributor

@Alfxjx Alfxjx commented Mar 16, 2024

Description

Fixes #6433

process the undefined data in Eip838ExecutionError constructor to avoid an "read something from undefined" bug.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@codecov Codecov
Copy link

codecov bot commented Mar 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.99%. Comparing base (4358140) to head (b9c6117).
Report is 273 commits behind head on 4.x.

❗ Current head b9c6117 differs from pull request most recent head 933acc2

Please upload reports for the commit 933acc2 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##              4.x    #6905      +/-   ##
==========================================
+ Coverage   87.37%   91.99%   +4.62%     
==========================================
  Files         197      215      +18     
  Lines        7548     8172     +624     
  Branches     2059     2202     +143     
==========================================
+ Hits         6595     7518     +923     
+ Misses        953      654     -299
Flag Coverage Δ
UnitTests 91.99% <100.00%> (+4.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Muhammad-Altabba
Muhammad-Altabba suggested changes Mar 26, 2024
View reviewed changes
packages/web3-errors/test/unit/__snapshots__/errors.test.ts.snap
{
"cause": undefined,
"code": undefined,
"data": undefined,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code was already working when data is undefined. But it does not work when data is null. So, could you please update the tests?
Thanks,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I will look into it and fix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Alfxjx ,
Just to clarify that your code looks great! And what I proposed to update is only your tests. That is to test with null instead of undefined. Please, let me know if you need any help to finish this.
Thanks,

@jdevcs
Copy link
Contributor

jdevcs commented Apr 22, 2024

@Muhammad-Altabba could you update changelog and merge this PR, as seems @Alfxjx is away.

@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Jun 22, 2024
@jdevcs jdevcs removed the Stale Has not received enough activity label Jul 1, 2024
@jdevcs
Copy link
Contributor

jdevcs commented Jul 1, 2024

cc: @mconnelly8

@jdevcs jdevcs changed the base branch from 4.x to junaid/eip838fix July 11, 2024 12:36
@jdevcs jdevcs requested a review from Muhammad-Altabba July 11, 2024 12:38
@jdevcs
Copy link
Contributor

jdevcs commented Jul 11, 2024

this PR will be merged into 4.x via: web3:junaid/eip838fix

@jdevcs jdevcs merged commit 2b93c6a into web3:junaid/eip838fix Jul 11, 2024
1 check passed
@jdevcs jdevcs mentioned this pull request Jul 11, 2024
Merged
17 tasks
jdevcs added a commit that referenced this pull request Jul 12, 2024
@jdevcs @Alfxjx
@Muhammad-Altabba @avkos
fix(web3-errors): the undefined data in Eip838ExecutionError (#6905) (#…
6b80cf0 
…7147)

* fix(web3-errors): the undefined data in Eip838ExecutionError (#6905)

* fix(web3-errors): handle the undefined data in Eip838ExecutionError constructor(#6433)

* doc: update changelog

* Update CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com>
Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com>

* changelog update

---------

Co-authored-by: Xu Jianxiang <xjxtju@163.com>
Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com>
Co-authored-by: Oleksii Kosynskyi <oleksii.kosynskyi@gmail.com>
@luu-alex luu-alex mentioned this pull request Jul 24, 2024
Merged
17 tasks
julitabarelkowska
julitabarelkowska reviewed Aug 7, 2024
View reviewed changes
Copy link

@julitabarelkowska julitabarelkowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Julita Barelkowska

@swirlds-automation swirlds-automation mentioned this pull request Aug 20, 2024
Merged
julitabarelkowska
julitabarelkowska reviewed Aug 25, 2024
View reviewed changes
Copy link

@julitabarelkowska julitabarelkowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...

julitabarelkowska
julitabarelkowska reviewed Aug 28, 2024
View reviewed changes
Copy link

@julitabarelkowska julitabarelkowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤗

julitabarelkowska
julitabarelkowska reviewed Aug 28, 2024
View reviewed changes
Copy link

@julitabarelkowska julitabarelkowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AKJUS AKJUS mentioned this pull request Sep 12, 2024
Open
@aashutoshrathi aashutoshrathi mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 13, 2024
Open
Open
@swirlds-automation swirlds-automation mentioned this pull request Sep 17, 2024
Merged
@AKJUS AKJUS mentioned this pull request Sep 18, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Sep 22, 2024
Open
@HaLaGu1L HaLaGu1L mentioned this pull request Nov 3, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jdevcs jdevcs jdevcs left review comments

@julitabarelkowska julitabarelkowska julitabarelkowska left review comments

@avkos avkos avkos approved these changes

@luu-alex luu-alex Awaiting requested review from luu-alex

@Muhammad-Altabba Muhammad-Altabba Awaiting requested review from Muhammad-Altabba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot use 'in' operator to search for 'originalError' in null
5 participants
@Alfxjx @jdevcs @avkos @Muhammad-Altabba @julitabarelkowska